From f7cd91089fa8924aaf004618268358366f2cbcce Mon Sep 17 00:00:00 2001 From: Robert Clark Date: Fri, 23 Apr 2021 09:40:42 -0400 Subject: [PATCH 1/3] Do not lock nokogiri to 1.10, it has open CVEs Signed-off-by: Robert Clark --- heimdall_tools.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/heimdall_tools.gemspec b/heimdall_tools.gemspec index 4954908..7eb7fcd 100644 --- a/heimdall_tools.gemspec +++ b/heimdall_tools.gemspec @@ -33,7 +33,7 @@ Gem::Specification.new do |spec| spec.add_runtime_dependency 'git-lite-version-bump', '>= 0.17.2' spec.add_runtime_dependency 'httparty', '~> 0.18.0' spec.add_runtime_dependency 'json', '~> 2.3' - spec.add_runtime_dependency 'nokogiri', '~> 1.10.9' + spec.add_runtime_dependency 'nokogiri', '~> 1.11' spec.add_runtime_dependency 'openssl', '~> 2.1' spec.add_runtime_dependency 'thor', '~> 0.19' spec.add_development_dependency 'bundler' From 1fea2a6ca3dfb77a7b0e278c019d173ed135d580 Mon Sep 17 00:00:00 2001 From: Robert Clark Date: Fri, 23 Apr 2021 09:44:41 -0400 Subject: [PATCH 2/3] Target the earliest ruby version we support (2.5) with Rubocop Signed-off-by: Robert Clark --- .rubocop.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index 45dee70..39f236c 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -3,7 +3,7 @@ inherit_from: .rubocop_todo.yml AllCops: NewCops: enable - TargetRubyVersion: 2.4 + TargetRubyVersion: 2.5 Exclude: - Gemfile - Rakefile From 72a2d8f16e4aa566159d54fd5ef0b7ab16cc3c57 Mon Sep 17 00:00:00 2001 From: Robert Clark Date: Fri, 23 Apr 2021 09:47:06 -0400 Subject: [PATCH 3/3] Properly name Heimdall tools test Github Action step Signed-off-by: Robert Clark --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c85de3d..a074746 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -7,7 +7,7 @@ on: branches: [ master ] jobs: - lint: + test: strategy: matrix: platform: [ubuntu-16.04, ubuntu-latest, macos-latest, windows-latest]