Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add PWA support and improve lighthouse performance #18

Open
mithi opened this issue Sep 1, 2020 · 9 comments
Open

feat: Add PWA support and improve lighthouse performance #18

mithi opened this issue Sep 1, 2020 · 9 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed up for grabs

Comments

@mithi
Copy link
Owner

mithi commented Sep 1, 2020

Screen Shot 2020-09-01 at 9 18 00 PM

@arjita-mitra
Copy link

arjita-mitra commented Sep 1, 2020

Hello, @mithi I would like to contribute. I am a first-time contributor so please guide me. I have good experience in front end especially react and javascript. I have worked on lighthouse performance in the past. :-)

@arjita-mitra
Copy link

@mithi is there any contribution guideline for your project? Please share.

@mithi
Copy link
Owner Author

mithi commented Sep 1, 2020

@mithi is there any contribution guideline for your project? Please share.

You can follow the guidelines here: https://github.com/mithi/hexapod/blob/master/CONTRIBUTING.md

Thank you! :)

@mithi
Copy link
Owner Author

mithi commented Sep 1, 2020 via email

@arjita-mitra
Copy link

Sure @mithi .

@arjita-mitra
Copy link

Hello @mithi
Can you assign this issue to me? I have started working on it.

@mithi
Copy link
Owner Author

mithi commented Sep 7, 2020 via email

@arjita-mitra
Copy link

arjita-mitra commented Sep 8, 2020

Hello @mithi
It's been a while I am stuck at this issue, because of this I am unable to test service worker also. Service workers can be tested in production mode only. So I tried to deploy it in a static server following this-
https://create-react-app.dev/docs/deployment/
https://create-react-app.dev/docs/making-a-progressive-web-app/

I am getting an error, Uncaught SyntaxError: Unexpected token '<'. I read multiple articles to resolve this issue, but no luck so far. So far I understood its some issue with the homepage url in package.json. This message is important -

The project was built assuming it is hosted at /hello-tiny-box/.
You can control this with the homepage field in your package.json.

Below is some reference regarding this issue.

webpack/webpack#2882 (comment)
https://stackoverflow.com/questions/54340240/create-react-app-build-uncaught-syntaxerror-unexpected-token
https://stackoverflow.com/questions/51071848/blank-screen-for-express-react-app-at-production-uncaught-syntaxerror-unexpect

Any help would be appreciated.

@arjita-mitra
Copy link

@mithi
My commit arjita-mitra@69591ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed up for grabs
Projects
None yet
Development

No branches or pull requests

2 participants