Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge improvements upstream #2

Open
hankertrix opened this issue Sep 28, 2024 · 8 comments
Open

Merge improvements upstream #2

hankertrix opened this issue Sep 28, 2024 · 8 comments
Assignees
Labels
question Further information is requested

Comments

@hankertrix
Copy link

As the title states, would you be willing to submit a patch to the upstream repository with the improvements you have made?

@gorillamoe gorillamoe self-assigned this Sep 28, 2024
@gorillamoe gorillamoe added the question Further information is requested label Sep 28, 2024
@gorillamoe
Copy link
Member

I'm not using the theme anymore, but if @uloco wants to get rid of lush as a dependency, I can work on a PR for that.

@hankertrix
Copy link
Author

hankertrix commented Sep 29, 2024

Awesome, that’ll be great!

I’ll open an issue in the upstream repository.

Here’s the issue:
uloco/bluloco.nvim#89

@uloco
Copy link

uloco commented Sep 29, 2024

Hey there. This is awesome! I'll be very happy to remove lush. Just don't have much time for programming stuff lately. This sounds like a neat idea. Please make a PR so we can test it out. Thanks.

@uloco
Copy link

uloco commented Jan 9, 2025

Do you still have any plans on doing so? If not I'll probably start working on this my own...

@gorillamoe
Copy link
Member

Do you still have any plans on doing so? If not I'll probably start working on this my own...

I've not started and have no plans on doing that in the next weeks, so feel free to tackle this on your own. You might want to take a look at the fork. I think you can quickly grasp what is going on there and it's pretty easy to convert the current theme I guess.

@uloco
Copy link

uloco commented Jan 9, 2025

alright ty

@uloco
Copy link

uloco commented Jan 9, 2025

also what was your reason to remove the terminal themes? how should I add them to the repo so people can find them easily?

@gorillamoe
Copy link
Member

also what was your reason to remove the terminal themes? how should I add them to the repo so people can find them easily?

The only reasoning was that I think that they should belong to their own dedicated repo. I wanted to have a clear distinction between "this is a neovim theme" and this is "a terminal theme".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants