-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge improvements upstream #2
Comments
I'm not using the theme anymore, but if @uloco wants to get rid of lush as a dependency, I can work on a PR for that. |
Awesome, that’ll be great! I’ll open an issue in the upstream repository. Here’s the issue: |
Hey there. This is awesome! I'll be very happy to remove lush. Just don't have much time for programming stuff lately. This sounds like a neat idea. Please make a PR so we can test it out. Thanks. |
Do you still have any plans on doing so? If not I'll probably start working on this my own... |
I've not started and have no plans on doing that in the next weeks, so feel free to tackle this on your own. You might want to take a look at the fork. I think you can quickly grasp what is going on there and it's pretty easy to convert the current theme I guess. |
alright ty |
also what was your reason to remove the terminal themes? how should I add them to the repo so people can find them easily? |
The only reasoning was that I think that they should belong to their own dedicated repo. I wanted to have a clear distinction between "this is a neovim theme" and this is "a terminal theme". |
As the title states, would you be willing to submit a patch to the upstream repository with the improvements you have made?
The text was updated successfully, but these errors were encountered: