Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Identifier Error When Exporting Environment Variable 12B_DIR #232

Open
alexander-knox opened this issue Oct 19, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@alexander-knox
Copy link

Python -VV

Python 3.12.3 (main, Sep 11 2024, 14:17:37) [GCC 13.2.0]

Pip Freeze

annotated-types==0.7.0
attrs==24.2.0
certifi==2024.8.30
charset-normalizer==3.4.0
docstring_parser==0.16
filelock==3.16.1
fire==0.7.0
fsspec==2024.9.0
idna==3.10
Jinja2==3.1.4
jsonschema==4.23.0
jsonschema-specifications==2024.10.1
MarkupSafe==3.0.2
mistral_common==1.4.4
mistral_inference==1.5.0
mpmath==1.3.0
networkx==3.4.1
numpy==2.1.2
nvidia-cublas-cu12==12.1.3.1
nvidia-cuda-cupti-cu12==12.1.105
nvidia-cuda-nvrtc-cu12==12.1.105
nvidia-cuda-runtime-cu12==12.1.105
nvidia-cudnn-cu12==9.1.0.70
nvidia-cufft-cu12==11.0.2.54
nvidia-curand-cu12==10.3.2.106
nvidia-cusolver-cu12==11.4.5.107
nvidia-cusparse-cu12==12.1.0.106
nvidia-nccl-cu12==2.20.5
nvidia-nvjitlink-cu12==12.6.77
nvidia-nvtx-cu12==12.1.105
pillow==10.4.0
pydantic==2.9.2
pydantic_core==2.23.4
referencing==0.35.1
regex==2024.9.11
requests==2.32.3
rpds-py==0.20.0
safetensors==0.4.5
sentencepiece==0.2.0
setuptools==75.2.0
simple-parsing==0.1.6
sympy==1.13.3
termcolor==2.5.0
tiktoken==0.7.0
torch==2.4.1
triton==3.0.0
typing_extensions==4.12.2
urllib3==2.2.3
xformers==0.0.28.post1

Reproduction Steps

  1. Inside of a Bash shell, attempt to execute the command example shown on line 79 of the README.md file located in this project's root directory, i.e. "export 12B_DIR=$MISTRAL_MODEL/12B_Nemo"
  2. Receive the error: "-bash: export: `12B_DIR=/home/my/path/mistral_models/12B_Nemo': not a valid identifier"

Expected Behavior

Successful export of the environment variable.

Additional Context

Other shells may or may not have this problem? But in Bash, environment variables must not begin with a digit or number.

Suggested Solutions

Perhaps the variable could be renamed to DIR_12B?

First issue I've ever found. Hope this is OK. Thank you for your hard work on this amazing project.

@alexander-knox alexander-knox added the bug Something isn't working label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant