Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unify selection events #191

Open
miroiu opened this issue Jan 8, 2025 · 0 comments
Open

[Bug] Unify selection events #191

miroiu opened this issue Jan 8, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@miroiu
Copy link
Owner

miroiu commented Jan 8, 2025

Two SelectionChanged events are triggered when calling NodifyEditor.EndSelecting if the selection contains both connections and item containers.

To Reproduce

  1. Select at least one connection and one item container
  2. Start and complete a new selection in the editor by clicking on empty space

Expected behavior
I would expect a single (custom?) SelectionChanged event to be raised, containing information about the selected and deselected connections and items.

Additional context
Implementing correct behavior for selection undo/redo may be challenging without this improvement.

@miroiu miroiu added the bug Something isn't working label Jan 8, 2025
@miroiu miroiu self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant