chore: upgrade Node version needed to 14.* #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exelord
requested changes
Jul 7, 2021
Gorzas
force-pushed
the
hotfix-145/fix-auto-import-dependency
branch
from
dca8237 to
5e5adc1
Compare
Gorzas
changed the title
Exelord
requested changes
Jul 19, 2021
Gorzas
force-pushed
the
hotfix-145/fix-auto-import-dependency
branch
from
5e5adc1 to
34dc56c
Compare
|
There is one more thing that bothers me 🤔 why all tests are passing on node 12 on CI? |
I think the problem I had was with npm v6 not with node v12. In the tests it's installing the latest NPM version. |
|
It seems I have to do another change. Tests are failing for |
Merged
|
@esbanarango we can close this, as we have updated to node v18. When we move to v2 addon the node version is not anymore necessary to specificy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #145