Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListenBucketNotificationAsync Test1, Test2 and Test3` needs to be cleaned up. #1139

Open
ebozduman opened this issue Jul 24, 2024 · 0 comments

Comments

@ebozduman
Copy link
Collaborator

The following 2 functional tests needs to be cleaned up:

  • ListenBucketNotificationAsync_Test2
    &
  • ListenBucketNotificationAsync_Test3

First of all, they are not async methods, so the word Async needs to be removed from the names.
Second, there are unused/unnecessary code that can be cleaned up as it is done in PR #1130 for test ListenBucketNotificationAsync_Test1.

Last, we also need to remove the calls to Task.Delay(N) where the N is the wait time in milliseconds.
At this point, values of N are arbitrarily chosen in our code. Instead, we can make it like a wait loop with a time-out value, where we check the status of the task or object, whatever we are waiting for in each step, and keep checking and waiting until the expected happens.

@ebozduman ebozduman changed the title Functioal tests ListenBucketNotificationAsync_Test2 & .._Test3 needs to be cleaned up. ListenBucketNotificationAsync Test1, Test2 and Test3` needs to be cleaned up. Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant