You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following 2 functional tests needs to be cleaned up:
ListenBucketNotificationAsync_Test2
&
ListenBucketNotificationAsync_Test3
First of all, they are not async methods, so the word Async needs to be removed from the names.
Second, there are unused/unnecessary code that can be cleaned up as it is done in PR #1130 for test ListenBucketNotificationAsync_Test1.
Last, we also need to remove the calls to Task.Delay(N) where the N is the wait time in milliseconds.
At this point, values of N are arbitrarily chosen in our code. Instead, we can make it like a wait loop with a time-out value, where we check the status of the task or object, whatever we are waiting for in each step, and keep checking and waiting until the expected happens.
The text was updated successfully, but these errors were encountered:
ebozduman
changed the title
Functioal tests ListenBucketNotificationAsync_Test2 & .._Test3 needs to be cleaned up.ListenBucketNotificationAsync Test1, Test2 and Test3` needs to be cleaned up.
Jul 24, 2024
The following 2 functional tests needs to be cleaned up:
ListenBucketNotificationAsync_Test2
&
ListenBucketNotificationAsync_Test3
First of all, they are not async methods, so the word
Async
needs to be removed from the names.Second, there are unused/unnecessary code that can be cleaned up as it is done in PR #1130 for test
ListenBucketNotificationAsync_Test1
.Last, we also need to remove the calls to
Task.Delay(N)
where theN
is the wait time in milliseconds.At this point, values of
N
are arbitrarily chosen in our code. Instead, we can make it like a wait loop with a time-out value, where we check the status of the task or object, whatever we are waiting for in each step, and keep checking and waiting until the expected happens.The text was updated successfully, but these errors were encountered: