Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule pr_vulnerability_check message when no patch exists #274

Open
eleftherias opened this issue Jan 15, 2025 · 0 comments
Open

Rule pr_vulnerability_check message when no patch exists #274

eleftherias opened this issue Jan 15, 2025 · 0 comments
Labels
enhancement New feature or request P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage

Comments

@eleftherias
Copy link
Contributor

Given I have a profile with the pr_vulnerability_check rule
When I create a PR that has vulnerable dependencies
And none of the vulnerable dependencies have a fixed version
Then the review message should be "Minder found vulnerable dependencies in this PR, but could not find a new version of the dependency that is not vulnerable. Please push an updated version."

Given I have a profile with the pr_vulnerability_check rule
When I create a PR that has vulnerable dependencies
And at lease one of the vulnerable dependencies has a fixed version
Then the review message should remain unchanged, as "Minder found vulnerable dependencies in this PR. Either push an updated version or accept the proposed changes. Note that accepting the changes will include Minder as a co-author of this PR."

Note that we are rewriting the pr_vulnerability_check ruletype to make it more generic. Let's not change the Minder built-in vulncheck evaluation step, and instead apply this change only after the rewrite.

@eleftherias eleftherias added enhancement New feature or request P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage
Projects
None yet
Development

No branches or pull requests

1 participant