Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache key #33

Open
jorisroling opened this issue Dec 2, 2014 · 1 comment
Open

Cache key #33

jorisroling opened this issue Dec 2, 2014 · 1 comment

Comments

@jorisroling
Copy link

Hi Nigel,

I think there is a error in the cacheFilenameForURL:atSize:atScaleFactor:atPage: method. It bases the cacheRoot on [ filePath lastPathComponent ], at that is not enough when different PDF's have the same lastPathComponent. I changed it to [ resourceURL description ] and now the full URL is considered in determining the MD5 key. And no more wrong cache hits here...

Regards,
Joris
@mindbrix
Copy link
Owner

mindbrix commented Dec 5, 2014

Hi Joris. Thanks for that observation. I shall update...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mindbrix @jorisroling