Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api basic auth not works if api_secret_path file created failed #2300

Open
qtumweiyu opened this issue Jan 6, 2019 · 4 comments
Open

Api basic auth not works if api_secret_path file created failed #2300

qtumweiyu opened this issue Jan 6, 2019 · 4 comments

Comments

@qtumweiyu
Copy link

Hi, when i running grin server in a docker, i suddenly found that the api basic auth not worked.

After some test, i found that the api_secret_path is set under a not exists path in the server config file, and when i change the path to an exists dir, it works.

@hashmap
Copy link
Contributor

hashmap commented Jan 11, 2019

Works as designed, what behavior would you expect in this case?

@qtumweiyu
Copy link
Author

Well, I think a warning or notice is better than silent disable😂

@0xmichalis
Copy link
Contributor

If grin cannot read the auth secret that is defined in the config, it should probably exit with a non-zero code.

@yeastplume
Copy link
Member

Reported long ago but appears a valid concern. Has anyone verified behaviour on the current code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants