Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust-yaml dependency must be updated #2175

Open
hashmap opened this issue Dec 18, 2018 · 4 comments
Open

Rust-yaml dependency must be updated #2175

hashmap opened this issue Dec 18, 2018 · 4 comments

Comments

@hashmap
Copy link
Contributor

hashmap commented Dec 18, 2018

Currently we use 0.4.2 (used by serde) and 0.3.5 (used by clap). Cargo audit is unhappy:

$cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 17 security advisories (from /home/ubuntu/.cargo/advisory-db)
    Scanning Cargo.lock for vulnerabilities (311 crate dependencies)
error: Vulnerable crates found!

ID:      RUSTSEC-2018-0006
Crate:   yaml-rust
Version: 0.3.5
Date:    2018-09-17
URL:     https://github.com/chyh1990/yaml-rust/pull/109
Title:   Uncontrolled recursion leads to abort in deserialization
Solution: upgrade to: >= 0.4.1

error: 1 vulnerability found!

I sent a PR against clap, opening this issue to track the update
clap-rs/clap#1396

@hashmap hashmap added the task label Dec 18, 2018
@quentinlesceller quentinlesceller changed the title Rust-yaml depenedncy must be updated Rust-yaml dependency must be updated Dec 20, 2018
@hashmap
Copy link
Contributor Author

hashmap commented Mar 26, 2019

It has been fixed in clap clap-rs/clap#1415 waiting for a release

@quentinlesceller
Copy link
Member

Looks like it won't be release clap-rs/clap#1439.

@yeastplume
Copy link
Member

Still outstanding, and looks as if ncurses and pancurses have been added to the audit unhappiness mix.

@quentinlesceller
Copy link
Member

Looks like there is a 0.3.0 beta-1. So hopefully that should be fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants