Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync opens possible DoS against mining node #1654

Closed
ignopeverell opened this issue Oct 3, 2018 · 1 comment
Closed

Sync opens possible DoS against mining node #1654

ignopeverell opened this issue Oct 3, 2018 · 1 comment
Labels
Milestone

Comments

@ignopeverell
Copy link
Contributor

#1643 aimed to fix an issue where a mining node adds a block while syncing. This results in resetting the header head which then confuses sync (and possibly other parts of the system).

However, as mentioned by @antiochp this opens up a possible attack:

Miner is fully sync'd
Miner happily mining on latest block
peer advertises new fork with greater cumulative difficulty
Miner kicks into sync mode and stops mining
turns out peer was lying about the fork
Miner now furious

There ought to be away we can prevent the attack without causing the previous issue (i.e. some "syncing but not trusting the total work yet"). This likely ties into #1139 as well.

@antiochp
Copy link
Member

antiochp commented Oct 3, 2018

syncing but not trusting the total work yet

Would fit quite nicely with fast-fast-sync (flyclient, not yet downloaded all the headers) and other "async" things we can do with sync (verifying huge number of rangeproofs in the background etc.)

@ignopeverell ignopeverell added this to the Mainnet milestone Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants