Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix assignment operator in AssertInfo to comparison operator #39347

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fix assignment operator in AssertInfo to comparison operator #39347

wants to merge 2 commits into from
+0 −2

Conversation

SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Jan 16, 2025 •
edited
Loading

fix: #39346

Remove the problem line as it's redundant.

@SpadeA-Tang
init
a54a7b2 
Signed-off-by: SpadeA-Tang <[email protected]>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 16, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 16, 2025
@SpadeA-Tang
remove redundant
3143cec 
Signed-off-by: SpadeA-Tang <[email protected]>
@chasingegg
Copy link
Contributor

/lgtm

@SpadeA-Tang SpadeA-Tang mentioned this pull request Jan 16, 2025
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 16, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

rerun go-sdk

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.48%. Comparing base (75d7978) to head (3143cec).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (75d7978) and HEAD (3143cec). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (75d7978) HEAD (3143cec)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39347       +/-   ##
===========================================
- Coverage   81.03%   69.48%   -11.56%     
===========================================
  Files        1407      300     -1107     
  Lines      198527    26899   -171628     
===========================================
- Hits       160885    18691   -142194     
+ Misses      31983     8208    -23775     
+ Partials     5659        0     -5659
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.48% <ø> (-0.02%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
...nal/core/src/exec/operator/IterativeFilterNode.cpp 76.33% <ø> (-0.18%) ⬇️

... and 1108 files with indirect coverage changes

sre-ci-robot pushed a commit that referenced this pull request Jan 17, 2025
@SpadeA-Tang
fix: [2.5] fix assignment operator in AssertInfo to comparison operat…
47e410f 
…or (#39351)

cp #39347
issue: #39346

Signed-off-by: SpadeA-Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@chasingegg chasingegg

Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: wrong semantics in assertion
3 participants
@SpadeA-Tang @sre-ci-robot @chasingegg