Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Sparse_inverted] it should report error if trying to build sparse inverted index with dim_max_score_ratio=0.49 #39332

Open
1 task done
yanliang567 opened this issue Jan 16, 2025 · 2 comments
Assignees
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@yanliang567
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version: master-20250114-3e788f0f-amd64
- Deployment mode(standalone or cluster): standalone
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):2.6.0rc53

Current Behavior

it succeeded if building sparse inverted index with
params = {"index_type": index, "metric_type": "IP", "params": {"dim_max_score_ratio": 0.49}}
the valid dim_max_score_ratio is [0.5, 1.3], so it should fail

Expected Behavior

report error msg

Steps To Reproduce

Milvus Log

No response

Anything else?

No response

@yanliang567 yanliang567 added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 16, 2025
@yanliang567 yanliang567 self-assigned this Jan 16, 2025
@sparknack
Copy link

ack

@zhengbuqian zhengbuqian assigned sparknack and unassigned yanliang567 Jan 16, 2025
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 16, 2025
@yanliang567 yanliang567 added this to the 2.5.4 milestone Jan 16, 2025
@yanliang567
Copy link
Contributor Author

if flush before building index, the client hang and there pos errors in milvus logs:
[2025/01/16 08:34:45.540 +00:00] [WARN] [indexnode/task_scheduler.go:236] ["process task failed"] [error="failed to create index, C Runtime Exception: => failed to build index, invalid args at /workspace/source/internal/core/src/index/VectorMemIndex.cpp:272\n\n: segcore error[segcoreCode=2004]"] [errorVerbose="failed to create index, C Runtime Exception: => failed to build index, invalid args at /workspace/source/internal/core/src/index/VectorMemIndex.cpp:272: segcore error[segcoreCode=2004]\n(1) attached stack trace\n -- stack trace:\n | [github.com/milvus-io/milvus/pkg/util/merr.WrapErrSegcore\n](http://github.com/milvus-io/milvus/pkg/util/merr.WrapErrSegcore/n) | \t/workspace/source/pkg/util/merr/utils.go:1006\n | [github.com/milvus-io/milvus/internal/util/indexcgowrapper.HandleCStatus\n](http://github.com/milvus-io/milvus/internal/util/indexcgowrapper.HandleCStatus/n) | \t/workspace/source/internal/util/indexcgowrapper/helper.go:78\n | [github.com/milvus-io/milvus/internal/util/indexcgowrapper.CreateIndex\n](http://github.com/milvus-io/milvus/internal/util/indexcgowrapper.CreateIndex/n) | \t/workspace/source/internal/util/indexcgowrapper/index.go:114\n | [github.com/milvus-io/milvus/internal/indexnode.(*indexBuildTask).Execute\n](http://github.com/milvus-io/milvus/internal/indexnode.(*indexBuildTask).Execute/n) | \t/workspace/source/internal/indexnode/task_index.go:314\n | [github.com/milvus-io/milvus/internal/indexnode.(*TaskScheduler).processTask.func1\n](http://github.com/milvus-io/milvus/internal/indexnode.(*TaskScheduler).processTask.func1/n) | \t/workspace/source/internal/indexnode/task_scheduler.go:222\n | [github.com/milvus-io/milvus/internal/indexnode.(*TaskScheduler).processTask\n](http://github.com/milvus-io/milvus/internal/indexnode.(*TaskScheduler).processTask/n) | \t/workspace/source/internal/indexnode/task_scheduler.go:235\n | [github.com/milvus-io/milvus/internal/indexnode.(*TaskScheduler).indexBuildLoop.func1\n](http://github.com/milvus-io/milvus/internal/indexnode.(*TaskScheduler).indexBuildLoop.func1/n) | \t/workspace/source/internal/indexnode/task_scheduler.go:262\n | runtime.goexit\n | \t/go/pkg/mod/[golang.org/[email protected]/src/runtime/asm_amd64.s:1695\nWraps](http://golang.org/[email protected]/src/runtime/asm_amd64.s:1695/nWraps): (2) failed to create index, C Runtime Exception: => failed to build index, invalid args at /workspace/source/internal/core/src/index/VectorMemIndex.cpp:272\nWraps: (3) segcore error[segcoreCode=2004]\nError types: (1) *withstack.withStack (2) *errutil.withPrefix (3) merr.milvusError"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants