Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong streaming mockery package name #39261

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jan 14, 2025

issue: #39095
pr: #39260

@sre-ci-robot sre-ci-robot requested review from czs007 and sunby January 14, 2025 12:53
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 14, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (5199415) to head (64cac61).
Report is 6 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39261       +/-   ##
===========================================
+ Coverage   69.58%   81.04%   +11.45%     
===========================================
  Files         297     1400     +1103     
  Lines       26557   196815   +170258     
===========================================
+ Hits        18480   159499   +141019     
- Misses       8077    31694    +23617     
- Partials        0     5622     +5622     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core 69.58% <ø> (ø)
Go 82.99% <89.83%> (∅)

see 1102 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 14, 2025
@chyezh chyezh changed the title fix: wrong stremaing mockery package name fix: wrong streaming mockery package name Jan 15, 2025
@mergify mergify bot removed the ci-passed label Jan 15, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 15, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Jan 15, 2025
@sre-ci-robot sre-ci-robot merged commit 74246d8 into milvus-io:2.5 Jan 15, 2025
20 checks passed
@chyezh chyezh deleted the fix_streaming_mockery_failure_2_5 branch January 15, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants