Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Merge insert message of multi partitions in one shard as one message. #39027

Open
1 task done
chyezh opened this issue Jan 7, 2025 · 2 comments
Open
1 task done
Assignees
Labels
kind/enhancement Issues or changes related to enhancement
Milestone

Comments

@chyezh
Copy link
Contributor

chyezh commented Jan 7, 2025

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

  • Current Milvus split insert message on one shard at partition-wise.
  • When enabling partittion-key, one insert opeartion of one shard will be split into N message in wal. It's low performance when the partition num is huge, such as 1024. Make a huge write-multiply.

We need to refactor the insert message format, make one shard insert message into one message to prevent low performance insert operation.

Why is this needed?

No response

Anything else?

No response

@chyezh chyezh added the kind/enhancement Issues or changes related to enhancement label Jan 7, 2025
@chyezh
Copy link
Contributor Author

chyezh commented Jan 7, 2025

/assign

@chyezh chyezh changed the title [Enhancement]: Merge insert message of partition in one shard as one message. [Enhancement]: Merge insert message of multi partitions in one shard as one message. Jan 7, 2025
@xiaofan-luan
Copy link
Collaborator

agree, we should insert as one shard one message. Partition can be handled after written into WAL

@chyezh chyezh added this to the 3.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Development

No branches or pull requests

2 participants