Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: err degenerated to a new variable #35891

Merged

Conversation

fengjun2016
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 1, 2024
@fengjun2016 fengjun2016 force-pushed the bugfix/fix-err-2-new-variable branch from 154a28f to 11b95ab Compare September 1, 2024 08:18
Copy link
Contributor

mergify bot commented Sep 1, 2024

@fengjun2016 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@fengjun2016 fengjun2016 force-pushed the bugfix/fix-err-2-new-variable branch from 11b95ab to 72bc3da Compare September 1, 2024 12:57
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fengjun2016, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot removed the lgtm label Sep 2, 2024
Copy link
Contributor

mergify bot commented Sep 2, 2024

@fengjun2016 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (b2eb9fe) to head (ee19203).
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35891      +/-   ##
==========================================
- Coverage   81.60%   81.60%   -0.01%     
==========================================
  Files        1264     1264              
  Lines      150692   150729      +37     
==========================================
+ Hits       122976   122999      +23     
- Misses      22826    22840      +14     
  Partials     4890     4890              
Files with missing lines Coverage Δ
internal/datanode/importv2/task_l0_import.go 77.95% <100.00%> (+0.35%) ⬆️

... and 31 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/run-cpu-e2e

1 similar comment
@xiaofan-luan
Copy link
Collaborator

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 4, 2024
@czs007
Copy link
Collaborator

czs007 commented Sep 4, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 6eb8b3f into milvus-io:master Sep 4, 2024
16 checks passed
@fengjun2016 fengjun2016 deleted the bugfix/fix-err-2-new-variable branch September 7, 2024 13:16
chyezh pushed a commit to chyezh/milvus that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants