Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add skip load validation for create collection task #35761

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35737
Related to #35415

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 28, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 28, 2024
Signed-off-by: Congqi Xia <[email protected]>
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (c75f556) to head (de8399b).
Report is 3 commits behind head on 2.4.

Files Patch % Lines
internal/proxy/util.go 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35761      +/-   ##
==========================================
- Coverage   81.15%   71.93%   -9.22%     
==========================================
  Files        1056     1056              
  Lines      139227   139246      +19     
==========================================
- Hits       112992   100173   -12819     
- Misses      21940    34774   +12834     
- Partials     4295     4299       +4     
Files Coverage Δ
internal/proxy/task.go 90.22% <100.00%> (+0.01%) ⬆️
internal/proxy/util.go 91.76% <76.47%> (-0.06%) ⬇️

... and 225 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 28, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 1257588 into milvus-io:2.4 Aug 28, 2024
13 of 16 checks passed
@congqixia congqixia deleted the cp24/35737 branch August 30, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants