-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brightness and Hue #11
Comments
Not sure if this basdelfos#52 has anything to do with what you're describing? |
This kind bloke was able to fix brightness and temperature for bulbs plus added cover accessory but a lot of other code has to go into config file to use it. https://github.com/vitramir/homebridge-tuya-web/tree/feature/window-covering |
Version 0.3.1 (#12 specifically) should have a fix in-place for the color/colour issue possibly fixing your problem if basdelfos#52 was indeed the problem you encountered. If this issue persists feel free to re-open. |
I just went out and got a lamp to test this with, there indeed seem to be some issues with brightness and hue.
|
Yes, Vitramir fork has the fix for brightness and temperature not the hue though. I can also share the code he got me to add in my config file, if you want. |
I am running an LED strip through the Tuya app (not Hue) and am getting this error:
The error repeats itself every 30 seconds. Quite annoying... |
Hello could you please try and see if you can install the pre-release Please report back if this works for you or not 🙂 |
After updating to next version (v0.3.4) I am still getting the same:
|
Could you then please run the discovery as explained here and post the result that you get from that here (no need to open a new issue). |
Just so we are on the same page. |
Yes please, that will give me some information on the data structure that your LED strips sends and wants to receive. For example I know the brightness can be set on multiple locations and we use some vague techniques to determine which of the locations we need to get the brightness from. It seems like our techniques break with your device. Getting this info will help us improve that detection technique. |
here you go (the data output part for the LED strip):
|
Sadly your light strip does not support brightness through the home assistant API that this library uses (otherwise a |
@milo526 , this is the config i have in my config file for each and every bulb that Vitramir got me add it.
|
@milo526 I'm OK with the fact that the specific device does not expose its brightness functionality. It is what it is. |
Yeah, that is clearly a bug. It should not show this error at all, it should just not allow you to update or get the brightness. |
I have the same bug, but with a bulb. On TUYA platform the light have the "brightness" property. I have problem with color too :( |
BTW, in HomeKit for me it does actually show the ability to change the brightness level, and it does work! |
fratton/homebridge-tuya-web fork has fixed the Brightness problem and seems to work with led strips but the fork wont recognise my plugs,Where as your plugin does |
Since the devices I own don't seem to perform as described here, it is very hard for me to debug and thus fix this. Could somebody please try to isolate the relevant changes made by fratton (and possibly cherry-pick them and make a PR)? That would be highly appreciated. For everybody that is seeing the same problem, could you please run the discovery as explained here (the "How to check whether the api this library uses can control your device" heading) and post the result that you get from that here (no need to open a new issue). Please also state the following information
If at all possible please also post a listing to the device that you bought. This will help me as well as anybody else who might pick this issue up, the more information we have, the faster we can resolve this issue. |
hope this helps my discovery feedback Got devices
|
Would it not be possible to at least catch the exception so it doesn't cause a crash and disrupt the other devices. Maybe just provide a warning message instead if this is caught? |
Feel free to open a PR 😄 |
i have the same issue, here's the output of the discovery:
in the app there are basically 3 modes:
interesting find: when i switch to color mode (either in tuya or by using the color picker in eve) then the slider in EVE controls saturation, not brightness, I can pick colors, but these are sometimes off, and changing color always is accompanied by a kinda 'fade-out-fade-back brighness modulation) - I cant access actual brighness in EVE while in color mode what I miss most is a way to get back into 'white mode' in homekit/EVE, currently I need to use the tuya app to get this. in EVE I have two tabs (color/white), but selecting the 'white' tab and making changes there has no effect |
Perhaps i could have a look into this. |
still have not figured out why i only get it sometimes (it seems i dont get it in white mode at all - but I am not 100% sure yet - will keep an eye on this) |
|
i am on 0.3.3 ATM will try 0.3.4 edit: what is the best way to do that? do i first need to uninstall 0.3.3, or can I just go via command line using |
Assuming then that the "brightness" property is only sent to Homebridge when the bulb is in white mode.
It looks like @milo526 has rewritten the light_accessory.js file since v0.3.3 so it makes little sense for me to suggest potential changes. |
Thanks for looking into this @bwp91! My own colour light in colour modes gives:
The same device in white mode yields
So I believe your premise isn't exactly true. This also immediately shows one of the problems that this plugin has during development, there are 1000's of Tuya-based light bulbs and almost as many different payload types. |
Completely get this! My package for ewelink (focusing on sonoff brand) is just a total case of if...thens.... even from the same brand some devices use "brightness" property and other devices use "bright". some between 0-100... some between 10-100. its a nightmare. |
But i think it seems silly to look at your code for 0.3.3 if you did a major rewrite of the code anyway? |
@bwp91 I am not sure if that worked correctly. Installation worked without error, but plugin page still shows 0.3.3. (after a reboot) I then got some error shown and the pi went offline. after a cold reboot I am back in and getting variants of the same old error:
|
I don't know what exact rewrite you are talking about; I'm rewriting the library to use TypeScript currently, the 3.4.0 code is already on master. The TypeScript rewrite shouldn't impede on this too much. |
now I can use the EVE slider to change brighness in both modes. |
Ah let me rephrase! |
Ah, check! I don't feel comfortable releasing that release now since I'll be gone the next week with little access to my laptop. Please remind me in 10 days if I haven't released by then 😉 |
@bwp91 arrgghh... yes, you are right, there were two entries, I just did not notice it, the newer one was sorted quite to the bottom. if i should do any other tests or so, just let me know edit: interesting - in 0.3.4 the color control is totally gone for my bulb (in EVE&homekit)
is there a specific thing i can put in my config to get that back? |
My input here was to try and sort out any errors that were crashing Homebridge (as 1) I know @milo526 has said somewhere that his time is taken up at the moment and 2) I personally know how annoying it can be when Homebridge has to restart indefinitely). With regards to functionality (eg enabling colour) -- that would be almost impossible for me to implement as I don't own any tuya devices anymore. |
since I only got these errors in color mode - and color mode is not working in 0.3.4 - i get no more errors the error was only cosmetic from my perspective, but i hoped to get the color/white/hue/saturation features working. |
Reporting the same issue on Tuya lights with Colour and White (and scene) settings. Behaviour in White mode
Behaviour in Colour mode
Behaviour in Scene mode
Accessory details attached for each mode |
Well I didn't make the 10 days I said, it was 11. Both color and color temperature seems to work perfectly for me with the new beta release, could you all please try installing I would advice you to disable the polling options by removing the polling key from your configuration file (or clearing the value in homebridge-config-ui-x) |
@milo526 Hue and brightness work correctly now, but Homekit is very slow in updating the status. Also I was unable to add two lights to a group. (Which I could do in while on v0.3.3.) Update: I think the grouping issue is linked to the slow updating. All the groups I created eventually showed up. The light seems to be working now, but at times slow. Could just be Homekit. |
Hi there -- I just wanted to weigh in that I just installed the 0.3.4 beta and it solved the same issues I was running into with an outdoor pluggable dimmer. It also fixed the fact that I was getting hue settings when the only control I should have had is brightness. Thank you!! BTW: When 0.3.4 is released out of beta, will it auto-update since I now have the beta version installed? Or will I need to remove the beta and install the public release? Thanks! |
This issue has been fixed in the v0.4.2 release if you are still experiencing this issue, or are experiencing other issues, please open a new bug report. Thank you once again for this bug report, reports like these help make the plugin better! @ShahrumAmiri The plugin should update automatically. There are still some issues with regards to "requesting too quickly" if this is still an issue for you, please open a new issue or comment to another relevant open issue. |
Hi, does you plugin fixed brightness and hue for bulbs ?
The text was updated successfully, but these errors were encountered: