Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 Support #74

Open
pmcnano opened this issue Dec 27, 2018 · 5 comments
Open

V4 Support #74

pmcnano opened this issue Dec 27, 2018 · 5 comments

Comments

@pmcnano
Copy link

pmcnano commented Dec 27, 2018

The V3 API will be discontinued on January 27th or so. Do you plan on updating the gem?

EDIT: https://www.riotgames.com/en/DevRel/player-universally-unique-identifiers-and-a-new-security-layer

@oeN
Copy link
Collaborator

oeN commented Dec 28, 2018

Hi @pmcnano,

We've planned the update but is not scheduled yet. I think we will have a more precise schedule after January 11th.

I'll keep you posted and I'll update this Issue as soon as I have more details!

thanks!

@pmcnano
Copy link
Author

pmcnano commented Dec 28, 2018

@oeN That is awesome! I wasn't sure if you guys were active and was already looking into updating myself! ha. If you need help let me know!

@oeN
Copy link
Collaborator

oeN commented Dec 28, 2018

@pmcnano if you already started, why stopping now 😄
Any help is really appreciated!

@pmcnano
Copy link
Author

pmcnano commented Dec 28, 2018

@oeN I haven't. But I maybe will, if I do I will push a PR 😄, from the changes I've seen, I think it might be almost as easy as changing the URL's. I could be wrong tho.

@pmcnano
Copy link
Author

pmcnano commented Jan 29, 2019

@oeN I already pushed a PR based on the branch @fusillicode started. I'm using my fork atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants