Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Document picker is broken when MEDIA is disabled #1080

Closed
1 of 4 tasks
martingeorgiu opened this issue Jul 29, 2022 · 4 comments
Closed
1 of 4 tasks

[iOS] Document picker is broken when MEDIA is disabled #1080

martingeorgiu opened this issue Jul 29, 2022 · 4 comments
Labels
new issue An issue that hasn't yet been seen from the maintainer stale

Comments

@martingeorgiu
Copy link

Describe the bug
When you set Pod::PICKER_MEDIA = false and Pod::PICKER_AUDIO = false in Podfile and you want to pick just documents, then the plugin is partially broken on iOS. If you trigger the popup via pickFiles() and press "Cancel" to cancel it, everything works fine. But when you drag the topbar downwards instead of pressing "Cancel" button, then the Future does not complete. The cause of the issue is that presentationControllerDidDismiss method (which is called when the topbar is dragged downwards) in FilePickerPlugin.m is wrapped in #ifdef PICKER_MEDIA so it is not present when the PICKER_MEDIA is disabled.

Platform

  • Android
  • iOS
  • Web
  • Desktop

Platform OS version
15.5

@martingeorgiu martingeorgiu added the new issue An issue that hasn't yet been seen from the maintainer label Jul 29, 2022
@github-actions
Copy link

github-actions bot commented Aug 6, 2022

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Aug 6, 2022
@github-actions
Copy link

This issue was closed because it has been inactive for 14 days since being marked as stale.

@martingeorgiu
Copy link
Author

Hello @miguelpruivo, could you please reopen the issue? It is still actual, so it should be at least open:)

@stephane-archer
Copy link
Contributor

#1628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new issue An issue that hasn't yet been seen from the maintainer stale
Projects
None yet
Development

No branches or pull requests

2 participants