Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tests to validate typings #152

Open
MIchaelMainer opened this issue Jul 2, 2020 · 1 comment
Open

Enable tests to validate typings #152

MIchaelMainer opened this issue Jul 2, 2020 · 1 comment
Labels
ADO to GitHub automation label Issue caused by core project dependency modules or library area: test

Comments

@MIchaelMainer
Copy link
Contributor

MIchaelMainer commented Jul 2, 2020 •
edited by msgraph-bot bot
Loading

Tests were never completed. It appears we were blocked on using the ES6 module in Node. See Babel unexpected token import when running mocha tests.

We may want to consider adding test cases with tsd.

AB#7042
@ghost ghost added the ToTriage label Jul 2, 2020
@MIchaelMainer
Copy link
Contributor Author

We published typings to npm before we published to DefinatelyTyped. DefinatelyTyped PR validation caught an error. We should use the same (or similar) validation on our PRs so we catch errors like what was caught by the DefinatelyTyped.

@ddyett ddyett added the ADO to GitHub automation label Issue caused by core project dependency modules or library label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ADO to GitHub automation label Issue caused by core project dependency modules or library area: test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MIchaelMainer @ddyett