You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Newtonsoft.Json dependency of the SDK's authentication module, is no longer actively maintained. In the past we have also encountered trust issues with the signed Newtonsoft.Json package throwing verificationError 18 which interprets to
"Your file is signed but we don't trust it"
and PS SDK users, have raised this too as an issue for them. See #2741 and JamesNK/Newtonsoft.Json#2755
Expected behavior
Avoid Newtonsoft.Json related issues mentioned above by switching to System.Text.Json
How to reproduce
The task will include writing tests to cover the affected code segments and mitigate against any regressions before switching to system.text.json.
The current tricky work is the Json DOM handling in the 3 files below
Describe the bug
The Newtonsoft.Json dependency of the SDK's authentication module, is no longer actively maintained. In the past we have also encountered trust issues with the signed Newtonsoft.Json package throwing verificationError 18 which interprets to
"Your file is signed but we don't trust it"
and PS SDK users, have raised this too as an issue for them. See #2741 and JamesNK/Newtonsoft.Json#2755
Expected behavior
Avoid Newtonsoft.Json related issues mentioned above by switching to System.Text.Json
How to reproduce
The task will include writing tests to cover the affected code segments and mitigate against any regressions before switching to system.text.json.
The current tricky work is the Json DOM handling in the 3 files below
It should be easier to replace JsonConvert.SerializeObject with JsonSerializer.Seralize in other files like
msgraph-sdk-powershell/src/Authentication/Authentication/Cmdlets/InvokeMgGraphRequest.cs
Line 579 in f06dcb1
Acceptance Criteria
The text was updated successfully, but these errors were encountered: