Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several packages are rather old - consider upgrading to newer versions #4418

Open
NikolaMilosavljevic opened this issue Apr 25, 2023 · 4 comments

Comments

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Apr 25, 2023

There are some very old packages used by the build.

Microsoft.Extensions.FileSystemGlobbing - version 2.0.0

This is very old version, from 2017. It seems that most other projects in .NET are using version 6.0.0, which is also most downloaded from NuGet.org.

Microsoft.Build.Framework - version 16.0.461
Microsoft.Build.Utilities.Core - version 16.0.461

These versions are also rather old, from 2019.

@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage This item should be discussed in the next triage meeting. label Apr 25, 2023
@Evangelink
Copy link
Member

@MarcoRossignoli I recall you were doing something regarding FileSystemGlobbing for some SDK insertion. Is it related? Can we safely update?

Regarding the Microsoft.Build.*, I am afraid they are similar to Newtonsoft.Json and are dependencies that can be affecting user tests (@nohwnd can you confirm?). If that's the case we will need to discuss when is a good time to introduce this "breaking change".

@Evangelink Evangelink added engineering needs-attention exp: source-build and removed needs-triage This item should be discussed in the next triage meeting. labels Apr 26, 2023
@Evangelink
Copy link
Member

Ping @nohwnd @MarcoRossignoli

@MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli Marco Rossignoli FTE I recall you were doing something regarding FileSystemGlobbing for some SDK insertion. Is it related? Can we safely update?

Mmm I don't recall nothing related to the FileSystemGlobbing actually.

@MarcoRossignoli MarcoRossignoli pinned this issue May 4, 2023
@nohwnd nohwnd unpinned this issue Jun 5, 2023
@nohwnd nohwnd self-assigned this Jul 9, 2024
@MagicAndre1981
Copy link

After installing the .NET 9 SDK I was confused that Newtonsoft.Json.dll is Version 13.0.1 in C:\Program Files\dotnet\sdk\9.0.100\TestHostNetFramework. It is confusing that this older version is defined.

Why is this condition added?

<NewtonsoftJsonVersion>13.0.1</NewtonsoftJsonVersion>
<NewtonsoftJsonVersion Condition="'$(DotNetBuildSourceOnly)' == 'true'">13.0.3</NewtonsoftJsonVersion>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants