Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of source data lookup #3455

Closed
nohwnd opened this issue Mar 9, 2022 · 1 comment
Closed

Improve performance of source data lookup #3455

nohwnd opened this issue Mar 9, 2022 · 1 comment

Comments

@nohwnd
Copy link
Member

nohwnd commented Mar 9, 2022

Perf improvement from #1908:

  1. We can then replace this code which is reflection loading the assembly and traversing all the contained types and methods with code to do the same visitation using System.Reflection.Metadata.MetadataReader. And we can look up source information for the visited methods in the pdb MetadataReader in 2.

Avoiding reflection assembly load and type resolution in 3 above would also speed up the source information lookup (which we need to perform on every build for non-C# and non-VB projects) and also avoid concerns around loading the test assemblies into the test host process...

AB#1865120

@nohwnd
Copy link
Member Author

nohwnd commented Aug 3, 2023

Adding to sprint, because it looks like an reasonably simple perf improvement that we could address in some future sprint.

@nohwnd nohwnd closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant