Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer.exe reset/restart causes WT tray icon to disappear for the current instance #18057

Open
Hlsgs opened this issue Oct 15, 2024 · 1 comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@Hlsgs
Copy link

Hlsgs commented Oct 15, 2024

Windows Terminal version

1.21.2701.0 (and all previous builds, this is not a new issue)

Windows build number

Both W10 and W11 regardless of build number

Other Software

No response

Steps to reproduce

  1. Run WT with hide in notification area when minimized and always display in notification area enabled(the latter is optional)
  2. Use task manager to restart explorer.exe

Expected Behavior

The tray icon should reappear after the reset

Actual Behavior

The tray icon does not reappear after the reset. Only way to get it back is to completly close WT and start it again. This also has some (very) undesirable side-effects such as losing access to the stuff you have currently running(akin to #16755 ?). One would obviously not restart explorer.exe out of the blue but it does sometimes crash/restart on it's own, which has the same effect.

@Hlsgs Hlsgs added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 15, 2024
@Zeroes1
Copy link

Zeroes1 commented Oct 15, 2024

@DHowett I check latest canary build terminal-1.23.2852.0, also latest preview terminal-1.22.2702.0
check on Windows 10.0.19045.5011 (22H2)
[TEST: pskill64.exe explorer.exe and after manually ran again explorer.exe]
and confirm that it does not work - there is no re-registration of the icon in fact...

Strange situation i see what code exist for this, but don't work...

\src\cascadia\WindowsTerminal\WindowEmperor.cpp 
static const UINT WM_TASKBARCREATED = []() { return RegisterWindowMessageW(L"TaskbarCreated"); }();
...
        if (message == WM_TASKBARCREATED)
        {
            _notificationIcon->ReAddNotificationIcon();
            return 0;
        }


src\cascadia\WindowsTerminal\NotificationIcon.cpp
void NotificationIcon::ReAddNotificationIcon()
{
    Shell_NotifyIcon(NIM_ADD, &_notificationIconData);
    Shell_NotifyIcon(NIM_SETVERSION, &_notificationIconData);
}

some need also? I think need debug :/

@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Windowing Window frame, quake mode, tearout and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 16, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants