Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: closing powershell tab (multiple opened) hangs the application #1600

Closed
miaouPlop opened this issue Jun 25, 2019 · 3 comments
Closed
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@miaouPlop
Copy link

miaouPlop commented Jun 25, 2019

Environment

Windows build number:  Microsoft Windows [version 10.0.18362.30]
Windows Terminal version (if applicable): preview (from the Store)

Steps to reproduce

Launch the application. You have at least one tab. Now, open a new tab (any console type) and then close the first one (either by clicking the "close" button or by using the keyboard shortcut (mine is bind to ctrl+shift+w) or wheel-clicking).

Expected behavior

The tab should close fine and not block the entire application.
It should be noted that the first tab closes normally if you type "exit" (and chose to "closeonexit").

Actual behavior

The entire WindowsTerminal application is blocked and we have to close it with the processus manager.

This bug might be related to #1575, #1585, #1588 and #1530.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 25, 2019
@miaouPlop miaouPlop changed the title Bug Report Bug Report: closing first tab (multiple opened) hangs the application Jun 25, 2019
@miaouPlop miaouPlop changed the title Bug Report: closing first tab (multiple opened) hangs the application Bug Report: closing "previous" tab (multiple opened) hangs the application Jun 25, 2019
@miaouPlop miaouPlop changed the title Bug Report: closing "previous" tab (multiple opened) hangs the application Bug Report: closing powershell tab (multiple opened) hangs the application Jun 25, 2019
@miaouPlop
Copy link
Author

After some more testing it appears more convoluted than that. The crash only happens when trying to close a powershell console so #1530 seems really connected to that bug.

If I try to close any tab when I have three, the application hangs. 
If I try to close the last tab (when I have >= 3 tabs) then, the application hangs. 
If I now close a tab that is neither the first one nor the last one when I have >= 4 tabs, then it somehow "repairs" the index (to a certain extent) and I can close tabs rather randomly.

I can also reference this PR #892 that ended up by the fix microsoft/microsoft-ui-xaml#629.

@JacomusP
Copy link
Member

I was just about to open a new issue but I'm glad I found this one. Just wanted to say that I'm also experiencing this issue of closing the powershell tab that is opened by default.

@DHowett-MSFT
Copy link
Contributor

Probably #1445.

@DHowett-MSFT DHowett-MSFT added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants