Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make Docker Python version configurable #3937

Open
adam-lagoda opened this issue Jan 23, 2025 · 0 comments
Open

[Feature Request] Make Docker Python version configurable #3937

adam-lagoda opened this issue Jan 23, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@adam-lagoda
Copy link

Is your feature request related to a problem? Please describe.
When building a Docker image for the flow using
pf flow build --source ./flows/standard --output dist --format docker
the resulting Dockerfile contains
RUN conda create -n promptflow-serve python=3.9.16 [..]
by default.

It would be great if the python version of the deployment would be configurable.
The template for the Dockerfile can be found here
src/promptflow-devkit/promptflow/_sdk/data/docker/Dockerfile.jinja2

Describe the solution you'd like
I would like the python version to be configurable by a flag. If a flag is missing, then the version and fall to a default 3.9.16 as is now,

Describe alternatives you've considered
The python version for the Dockerfile conda environment could be parsable from the active environment that is used for the build.
If, if I run
pf flow build [...]
from my conda env with python 3.12.4, I would like to see
RUN conda create -n promptflow-serve python=3.12.4 [..]
in the Dockerfile

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant