Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing flexibility in Data Analysis Classes with default attributes #1297

Open
ebotiab opened this issue Feb 14, 2024 · 1 comment
Open

Comments

@ebotiab
Copy link
Contributor

ebotiab commented Feb 14, 2024

In the implementations of the abstract class ReaderBase, there is currently no functionality to provide default behavior for reading files. Furthermore, the default behavior of PandasAnalysisBuilder class could benefit from being extended by incorporating a default n attibute.

A possible approach is to introduce a new attribute in the CsvReader and JsonReader to be used as default kwargs in their methods read. Additionally, incorporating a default n attribute into the PandasAnalysisBuilder class to be used in the method generate_analysis would enhance its functionality.

@omri374
Copy link
Contributor

omri374 commented Mar 13, 2024

Hi @ebotiab, apologies for the late reply! By default behavior do you mean things like setting up encoding? That would be. a great addition to the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants