Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not alter database entries when running tests #32

Open
vincentsarago opened this issue Jan 14, 2022 · 0 comments
Open

Do not alter database entries when running tests #32

vincentsarago opened this issue Jan 14, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@vincentsarago
Copy link
Contributor

vincentsarago commented Jan 14, 2022

When running pcstac tests, we assume

docker-compose \
-f docker-compose.yml \
run --rm \
stac \
python /opt/src/pcstac/tests/loadtestdata.py
has being ran first.

This could be replaced by something like: https://github.com/developmentseed/planetary-computer-apis/blob/refactorTests/pcstac/tests/conftest.py#L19-L115

Note: ☝️ approach also remove the code duplication with pcstac.main

This is also linked to #31 because loadtestdata.py assume pypgstac is available in the environment (which should only be in the dev environment)

@vincentsarago vincentsarago added the bug Something isn't working label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant