Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Explain Version Symbols for OperatorKernels.md #23452

Open
axbycc-mark opened this issue Jan 21, 2025 · 3 comments
Open

[Documentation] Explain Version Symbols for OperatorKernels.md #23452

axbycc-mark opened this issue Jan 21, 2025 · 3 comments
Labels
contributions welcome external contributions welcome documentation improvements or additions to documentation; typically submitted using template

Comments

@axbycc-mark
Copy link

Describe the documentation issue

The OperatorKernels.md has three types of Opset Version entries.

  1. Plain number, eg 13
  2. List-like, eg [11, 18]
  3. Plus symbol, eg 9+

I would like some clarification on the meanings, especially the plus symbol. For example, GridSample is listed as opset 16+ for the CUDA provider. I assumed this meant it was implemented for Opset 20 as well, but this seems not to be the case.

Page / URL

https://github.com/microsoft/onnxruntime/blob/rel-1.20.0/docs/OperatorKernels.md

@axbycc-mark axbycc-mark added the documentation improvements or additions to documentation; typically submitted using template label Jan 21, 2025
@snnn
Copy link
Member

snnn commented Jan 22, 2025

I guess 16+ means 16.

See the comment at :

// allow match if the kernel def has an end version. if it does not, all we know is that the kernel supported

@axbycc-mark
Copy link
Author

Hmm, but why the plus sign?

@snnn snnn added the contributions welcome external contributions welcome label Jan 23, 2025
@snnn
Copy link
Member

snnn commented Jan 23, 2025

By mistake.

We should clean up our kernel registration code in https://github.com/microsoft/onnxruntime/blob/main/onnxruntime/core/providers/cpu/cpu_execution_provider.cc so that the generated document would not have a plus sign there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome external contributions welcome documentation improvements or additions to documentation; typically submitted using template
Projects
None yet
Development

No branches or pull requests

2 participants