Broken logic in ConfigurableRetryLogic

[debedb]

Driver version

12.9.0

SQL Server version

N/A

Client Operating System

Amazon Linux

JAVA/JVM version

11

Table schema

N/A

Problem

When run out of a folder such as /var/task, for example (in AWS lambda), the following occurs:

2025-01-08 00:44:39 67a87119-0069-48d8-90ad-5de8e2a32ee0 WARN  CompositeHandler:126 - handleRequest: Completed with an exception.
java.lang.StringIndexOutOfBoundsException: begin 0, end -6, length 10
at java.lang.String.checkBoundsBeginEnd(Unknown Source) ~[?:?]
at java.lang.String.substring(Unknown Source) ~[?:?]
at com.microsoft.sqlserver.jdbc.ConfigurableRetryLogic.getCurrentClassPath(ConfigurableRetryLogic.java:290) ~[task/:?]

This is due to hardcoded substring logic.

[machavan]

Hi @debedb

Thank you for reporting this issue. We are looking to address it.

As a temporary workaround, could you try to put the driver jar in a path that is longer than 16 characters. Also, was the mssql-jdbc driver jar file name renamed to a shorter name in your case?

[debedb]

Hi @machavan

[SORRY EDITED: Hit save before I finished, flagging with comment]

As a temporary workaround I just did this from my end (there's no need to search for the properties inside the driver anyway in this case): debedb@bc16e15#diff-432635069536b5052b4fffe63d32f62edd8f967ee01a917b3e4729d3c1c1a7ce

I think I understand why that magic of 16 characters was there (backtracking from running in an IDE. The problem is that it breaks in issues like awslabs/aws-athena-query-federation#2510 but seems only if the directory name is long enough.

[Jeffery-Wasty]

Hi @debedb,

Apologies for the above oversight. I have linked a PR that I believe will resolve this issue. We'll look to get it into a release asap.