Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirects should not pass along the authorization header for security and usability reasons #547

Open
bbowman opened this issue Oct 20, 2020 · 1 comment
Open

Redirects should not pass along the authorization header for security and usability reasons #547

bbowman opened this issue Oct 20, 2020 · 1 comment

Comments

@bbowman
Copy link
Member

bbowman commented Oct 20, 2020

Apple does this by default (see Alamofire/Alamofire#798) but it appears the Windows http implementation give flexibility here. To be consistent across platforms as well not leak auth tokens to other locations, the auth header should be removed.
@jasonsandlin
Copy link
Member

jasonsandlin commented Oct 20, 2020 •
edited
Loading

Does your outstanding PR adds this for redirects for to the Windows HTTP path right? And prior to your change redirects happen but include the auth token is that right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbowman @jasonsandlin