-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure 3XX responses without location header do not throw #163
Comments
Hi @baywet is this issue open for contribution? |
@Haimantika yes! |
Amazing. How can I assign it to myself? My go skills are rusty, but I would love to give it a try. |
You can't because of permissions, but I just assigned it to you for the time being. Let us know if you have any question! |
Hi @baywet this is what I am planning to check in the unit test:
Let me know if I am thinking correctly or I need to take a different route. |
That'd be perfect! thanks for taking this on. |
Hi @baywet apologies I missed this notification. I am currently in a conference, will try to raise a PR by early next week. |
@baywet just raised a PR. I think this should be all. Let me know what you think. |
follow up to microsoft/kiota#4367
and microsoft/kiota#4190
Implement a unit test with a 304 response, no location header, check the request adapter returns null and doesn't throw.
Most likely this line will need to be adapted.
kiota-http-go/nethttp_request_adapter.go
Line 746 in 7f1b45b
The text was updated successfully, but these errors were encountered: