Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is the RootElement being cloned when creating a ParseNode? #276

Open
darrelmiller opened this issue May 6, 2023 · 3 comments
Open

Why is the RootElement being cloned when creating a ParseNode? #276

darrelmiller opened this issue May 6, 2023 · 3 comments
Assignees
@andrueastman
Labels
area:serialization Focused on functional modules of the product

Comments

@darrelmiller
Copy link
Member

https://github.com/microsoft/kiota-serialization-json-dotnet/blob/0b4c30ec7bede50cd1dbbc6ed2120f115da55854/src/JsonParseNodeFactory.cs#L38
@andrueastman
Copy link
Member

@darrelmiller I believe the reason is that the jsonDocument instance is disposable. Failing to clone will result in failed deserialization as the parseNode will hold a disposed object later in execution.

@sebastienlevert
Copy link

@andrueastman show we consider this one closed?

@andrueastman andrueastman self-assigned this Jul 9, 2024
@andrueastman
Copy link
Member

Transferring issue as part of #238

@andrueastman andrueastman transferred this issue from microsoft/kiota-serialization-json-dotnet Jul 9, 2024
@andrueastman andrueastman added the area:serialization Focused on functional modules of the product label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrueastman andrueastman

Labels
area:serialization Focused on functional modules of the product
Projects
Kiota
Status: Todo 📃
Milestone
No milestone
Development

No branches or pull requests
3 participants
@darrelmiller @andrueastman @sebastienlevert