Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to allow msvc /premissive- #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xaphier
Copy link

@xaphier xaphier commented Nov 11, 2020

This should fix the circular includes and allow building with /premissive-

@ghost
Copy link

ghost commented Nov 11, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ xaphier sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@jenatali jenatali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, looks great minus the one tabs/spaces issue.

@@ -3,269 +3,276 @@
#pragma once
namespace D3D12TranslationLayer
{
template<>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You overwrote the spaces in this file with tabs. Please switch back to spaces.

@jenatali jenatali linked an issue Nov 11, 2020 that may be closed by this pull request
@jenatali
Copy link
Member

Ping @xaphier, if you're able to fix the spacing issues and sign the CLA, I'd be happy to merge this.

@jenatali jenatali added the bug Something isn't working label May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependency in include files
2 participants