Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo and site config key paginate deprecated: update todo #246

Open
yada opened this issue Oct 20, 2024 · 2 comments
Open

Hugo and site config key paginate deprecated: update todo #246

yada opened this issue Oct 20, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@yada
Copy link
Member

yada commented Oct 20, 2024

Reason/Context

WARN deprecated: site config key paginate was deprecated in Hugo v0.128.0 and will be removed in a future release. Use pagination.pagerSize instead.

This is coming from ".Site.DisqusShortname" usage.

Description

We need to address this warning because the paginate configuration key in Hugo was deprecated in version 0.128.0. Continuing to use it could result in broken functionality in future releases when it's removed. To ensure our site remains compatible and functions smoothly with future Hugo updates, we should update the key to pagination.pagerSize.

Implementation ideas

Info here:
https://discourse.gohugo.io/t/pagination-deprecated-error/51571/2

@yada yada added kind/enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 20, 2024
@ahmedkhalid7
Copy link

Hi @yada, I wanted to start contributing to open source projects, and I came across your issue to start with. I think I understand what the issue is, but I can't completely grasp what the solution would be. Is it simply to replace any occurrence of .Site.DisqusShortname with pagination.pagerSize throughout the entire Microcks repository?

@yada
Copy link
Member Author

yada commented Oct 27, 2024

Thanks for reaching out and welcome. Yes it looks like a query replace on website should work. Please fork and test using the Hugo server command to see if it solve the issue and all pages are still working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants