Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring setChannelRpcTimeout #106

Open
glenjamin opened this issue Aug 3, 2020 · 1 comment
Open

Allow configuring setChannelRpcTimeout #106

glenjamin opened this issue Aug 3, 2020 · 1 comment

Comments

@glenjamin
Copy link

I've been trying to debug an error during topology setup, and I think I've narrowed it down to a failed queueDeclare call. This was very hard to figure out, as it looked a lot like a hanging process - but I've managed to poke around enough to realise that the default rpc timeout response is 10 minutes (which seems like a bad default to me, but that's a different issue).

https://github.com/rabbitmq/rabbitmq-java-client/blob/5.8.x-stable/src/main/java/com/rabbitmq/client/ConnectionFactory.java#L1446-L1456

As far as I can tell, it isn't possible to override this parameter.

It would be good to extend the options to cover setting this.

Would it also be reasonable to extend an open interface for future settings, either by mapping keys to calls via reflection, or by exposing a callback which would be passed the ConnectionFactory and could modify it?

@michaelklishin
Copy link
Owner

Accepting a connection factory instance or a function that can modify it is the way to go. That's how several clients make socket settings configurable, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants