Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newtypes for less safe serialization of Map / Set / etc? #114

Open
mgsloan opened this issue Aug 2, 2017 · 0 comments
Open

Add newtypes for less safe serialization of Map / Set / etc? #114

mgsloan opened this issue Aug 2, 2017 · 0 comments

Comments

@mgsloan
Copy link
Owner

mgsloan commented Aug 2, 2017

A check was added here to ensure that Map / Set are ascending, disallowing construction of invalid Map / Set. https://github.com/fpco/store/pull/109/files#diff-9ead574b8096a8cfea1c3a95c0f964d1R290

One thing we should do is benchmark whether it's even worth it to do this vs just converting normally from list. It could be we're losing all the benefits of fromAscList.

Either way, should have a way to do the fast thing when the input is trusted.

@mgsloan mgsloan added this to the P2: Should milestone Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant