Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently set FG and BG colors #3

Closed
AndydeCleyre opened this issue Aug 6, 2020 · 3 comments · Fixed by #4
Closed

Consistently set FG and BG colors #3

AndydeCleyre opened this issue Aug 6, 2020 · 3 comments · Fixed by #4

Comments

@AndydeCleyre
Copy link

Thanks for this theme!

I don't know if this does now or plans to in the future support color schemes (or live scheme switching, as mdBook does), but looking at the example it's apparent that in some places one of the FG or BG color is forced, while the other is left to the user's browser preference. This yields uncertain and potentially illegible results:

image

If a FG or BG color is set, please also set the other, so that contrast can be ensured.

To reproduce in Firefox, set preferred FG and BG colors to light on dark:

image
@mgeier mgeier mentioned this issue Aug 6, 2020
Merged
@mgeier
Copy link
Owner

mgeier commented Aug 6, 2020

Thanks for the report!

I have tried the suggested Firefox setting and found that setting FG and BG on the <body> seems to fix the problem, see #4.

Can you please check if that works for you?

Do I have to add anything else?

I don't know if this does now or plans to in the future support color schemes (or live scheme switching, as mdBook does)

No, currently there is only one fixed color theme.
And yes, it would be great to have multiple color themes in the future.
And yes, it would be great to have live switching.

I've just created #5 to collect a few ideas, please feel free to contribute!

@AndydeCleyre
Copy link
Author

Thanks! The body looks good on the rendered link in #4. The top bar and nav element FG is light, but that may be intentional.

image

@mgeier
Copy link
Owner

mgeier commented Aug 6, 2020

Thanks for checking this out!

Thanks! The body looks good on the rendered link in #4. The top bar and nav element FG is light, but that may be intentional.

Yes, the light FG is intentional, it is supposed to get dark on hover.

But this, like everything, is of course open for discussion!

@mgeier mgeier closed this as completed in 235485a Aug 7, 2020
@mgeier mgeier closed this as completed in #4 Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSS: Add color and background-color to <body> mgeier/insipid-sphinx-theme
2 participants
@mgeier @AndydeCleyre