-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document MetalLB CRD parameters #277
Comments
Yep, makes sense |
Do you want to document the CRD parameters on the installation page? @liornoy @fedepaol |
I think the "Using the MetalLB Operator" section in the installation page could be a good place for it. |
Thanks, I'll work on it! Also the documentation also lags the operator installation steps right? First the CRD need to applied and then deploying the operator as a pod right? Edit: Alright there is one option to install this operator that's via operatorhub. |
Thanks! I'll review this soon :) |
@roopeshsn Thanks again! I think it's great that you put an example of metallb.yaml that includes all of the optional fields (I think it's only missing the "RuntimeClassName" field in this manifest). |
Thanks for the review! I think we'll put the example manifest on the installation page (https://github.com/metallb/metallb/blob/main/website/content/installation/_index.md#using-the-metallb-operator) and redirect readers to the APIs page ( https://metallb.universe.tf/apis/) for the detailed reference on parameter types by mentioning a link. |
@roopeshsn hey, sorry to ping after so much time. Just checking if you are still interested in moving this forward. |
Sure, @fedepaol! What do you have in mind? What exactly should I need to work on? |
As for this pr: #239
we have many different parameters for MetalLB CRD, making the operator to deploy it
in different ways.
However, the doc only displays this lean CRD version:
We should document the different available parameters.
The text was updated successfully, but these errors were encountered: