Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document MetalLB CRD parameters #277

Open
liornoy opened this issue Nov 10, 2022 · 10 comments
Open

Document MetalLB CRD parameters #277

liornoy opened this issue Nov 10, 2022 · 10 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@liornoy
Copy link
Contributor

liornoy commented Nov 10, 2022

As for this pr: #239
we have many different parameters for MetalLB CRD, making the operator to deploy it
in different ways.
However, the doc only displays this lean CRD version:

apiVersion: metallb.io/v1beta1
kind: MetalLB
metadata:
  name: metallb
  namespace: metallb-system

We should document the different available parameters.

@fedepaol fedepaol added documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers labels Nov 10, 2022
@fedepaol
Copy link
Member

Yep, makes sense

@roopeshsn
Copy link

Do you want to document the CRD parameters on the installation page? @liornoy @fedepaol

@liornoy
Copy link
Contributor Author

liornoy commented Jan 14, 2024

I think the "Using the MetalLB Operator" section in the installation page could be a good place for it.

@roopeshsn
Copy link

roopeshsn commented Jan 14, 2024

I think the "Using the MetalLB Operator" section in the installation page could be a good place for it.

Thanks, I'll work on it! Also the documentation also lags the operator installation steps right? First the CRD need to applied and then deploying the operator as a pod right?

Edit: Alright there is one option to install this operator that's via operatorhub.

@roopeshsn
Copy link

roopeshsn commented Jan 15, 2024

I drafted the documentation for the additional operator parameters to create a custom resource of kind MetalLB. I referenced the types and tests written in the PR #239. Let me know if any changes are required @liornoy

@liornoy
Copy link
Contributor Author

liornoy commented Jan 15, 2024

Thanks! I'll review this soon :)

@liornoy
Copy link
Contributor Author

liornoy commented Jan 15, 2024

@roopeshsn Thanks again! I think it's great that you put an example of metallb.yaml that includes all of the optional fields (I think it's only missing the "RuntimeClassName" field in this manifest).
And on the bottom section you added a description for each field. I think this is a great and necessary addition.
We need to figure out where does it fit in metallb's website and later produce a PR that can we discuss on.
The relevant pages in the website imo would be https://metallb.universe.tf/apis/ and https://github.com/metallb/metallb/blob/main/website/content/installation/_index.md#using-the-metallb-operator

@roopeshsn
Copy link

roopeshsn commented Jan 16, 2024

Thanks for the review! I think we'll put the example manifest on the installation page (https://github.com/metallb/metallb/blob/main/website/content/installation/_index.md#using-the-metallb-operator) and redirect readers to the APIs page ( https://metallb.universe.tf/apis/) for the detailed reference on parameter types by mentioning a link.

@fedepaol
Copy link
Member

@roopeshsn hey, sorry to ping after so much time. Just checking if you are still interested in moving this forward.

@roopeshsn
Copy link

@roopeshsn hey, sorry to ping after so much time. Just checking if you are still interested in moving this forward.

Sure, @fedepaol! What do you have in mind? What exactly should I need to work on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants