Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refractor the existing controllers #30

Open
HeeManSu opened this issue Feb 29, 2024 · 2 comments
Open

Refractor the existing controllers #30

HeeManSu opened this issue Feb 29, 2024 · 2 comments

Comments

@HeeManSu
Copy link
Contributor

The TODO task has been added in several places. Complete them and refactor the other controllers for any potential improvements.

Screenshot from 2024-02-29 23-21-01
Screenshot from 2024-02-29 23-21-23
@khareyash05
Copy link
Contributor

On it! Kindly assign me this

@viferga
Copy link
Member

viferga commented Jun 3, 2024 •
edited
Loading

This is almost done but there's something remaining, all the lines containing this:

// TODO: Isn't this available inside protocol package? We MUST reuse it

This may be common and we either have to find one existing type/interface in the protocol or export the one in the faas into the protocol.

Maybe we can close this issue and create a new one only for the interface thing. What do you think @HeeManSu ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@viferga @khareyash05 @HeeManSu