From 183ba970a7a71de7a81541b74c413543523417d2 Mon Sep 17 00:00:00 2001 From: Kevin Hester Date: Tue, 20 Aug 2024 13:36:32 -0700 Subject: [PATCH] remove deprecated serial/bt logging options and unify in the new security option. Per discussion in https://github.com/meshtastic/firmware/issues/4375 no need to preserve the old options when changing to this new simpler single boolean because they were newish, rarely used and only for 'advanced' developers. --- meshtastic/config.proto | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/meshtastic/config.proto b/meshtastic/config.proto index 33fbd16a..2f734b7b 100644 --- a/meshtastic/config.proto +++ b/meshtastic/config.proto @@ -139,13 +139,6 @@ message Config { */ bool serial_enabled = 2[deprecated = true]; - /* - * By default we turn off logging as soon as an API client connects (to keep shared serial link quiet). - * Set this to true to leave the debug log outputting even when API is active. - * Moved to SecurityConfig - */ - bool debug_log_enabled = 3[deprecated = true]; - /* * For boards without a hard wired button, this is the pin number that will be used * Boards that have more than one button can swap the function with this one. defaults to BUTTON_PIN if defined. @@ -1014,12 +1007,6 @@ message Config { * Specified PIN for PairingMode.FixedPin */ uint32 fixed_pin = 3; - - /* - * Enables device (serial style logs) over Bluetooth - * Moved to SecurityConfig - */ - bool device_logging_enabled = 4[deprecated = true]; } message SecurityConfig { @@ -1054,15 +1041,10 @@ message Config { /* * By default we turn off logging as soon as an API client connects (to keep shared serial link quiet). - * Output live debug logging over serial. + * Output live debug logging over serial or bluetooth is set to true. */ bool debug_log_api_enabled = 6; - /* - * Enables device (serial style logs) over Bluetooth - */ - bool bluetooth_logging_enabled = 7; - /* * Allow incoming device control over the insecure legacy admin channel. */ @@ -1088,4 +1070,4 @@ message Config { SecurityConfig security = 8; SessionkeyConfig sessionkey = 9; } -} +} \ No newline at end of file