Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login button #120

Open
GamerBene19 opened this issue Jul 28, 2022 · 3 comments
Open

Add login button #120

GamerBene19 opened this issue Jul 28, 2022 · 3 comments
Labels
enhancement New feature or request low priority

Comments

@GamerBene19
Copy link
Collaborator

Currently there is a unnecessary divider if a user is logged out because we don't have a LoginButton
image

@GamerBene19 GamerBene19 added the enhancement New feature or request label Jul 28, 2022
@GamerBene19 GamerBene19 mentioned this issue Jul 28, 2022
@StealWonders
Copy link

I suggest removing the divider instead as there is no account system for normal users and then the admin link in the footer would be redundant.

@GamerBene19
Copy link
Collaborator Author

GamerBene19 commented Jul 31, 2022

and then the admin link in the footer would be redundant.

I'd not be. Logging in and going to the /admin page are two different actions. It's just for convenience that you get redirected to the login page if you are not logged in.

If a login button were to be added (and the admin-link removed (as you suggested with your comment of it beeing redundant)) - how would a user/admin access the admim-panel then?

Still, removing the divider in this case might be the better solution for now.

@StealWonders
Copy link

and then the admin link in the footer would be redundant.

I'd not be. Logging in and going to the /admin page are two different actions. It's just for convenience that you get redirected to the login page if you are not logged in.

If a login button were to be added (and the admin-link removed (as you suggested with your comment of it beeing redundant)) - how would a user/admin access the admim-panel then?

Still, removing the divider in this case might be the better solution for now.

For now it would be best to remove the divider as there is a login redirect for non-authenticated admins. There are no normal user accounts so a normal user shouldn't have to see a login button. Once normal user-accounts exist we should defiantly add a login icon next to a divider as suggested and also leave the admin link in the footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

2 participants