Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/oauth2/membrane does not work #1149

Open
rrayst opened this issue Jun 25, 2024 · 3 comments
Open

examples/oauth2/membrane does not work #1149

rrayst opened this issue Jun 25, 2024 · 3 comments
Assignees

Comments

@rrayst
Copy link
Contributor

rrayst commented Jun 25, 2024

Browser reports

Could not parse query: code=h88315fe2p4iftjr0e1qqs50n7&state=security_token=jbcvji764c02t05nk2qcn99sg0&url=/oauth2callback?code=br0li8ffdtvhhimhiidf5v7d7g&state=security_token=mi3rf4heqetlum51akf3idm2d&url=/
@t-burch
Copy link
Collaborator

t-burch commented Jun 28, 2024

@rrayst I could not reproduce any errors. At which point does this happen?

@t-burch t-burch self-assigned this Jun 28, 2024
@rrayst
Copy link
Contributor Author

rrayst commented Jul 2, 2024

unpack 5.5.2 distribution
console 1
examples/oauth2/membrane/authorization_server -> service-proxy.bat
console 2
examples/oauth2/membrane/client -> service-proxy.bat

firefox private tab
open http://localhost:2000/oauth2callback?code=br0li8ffdtvhhimhiidf5v7d7g&state=security_token=mi3rf4heqetlum51akf3idm2d&url=/
john / password
accept

-> error

@christiangoerdes
Copy link
Collaborator

The = in the query seems to be the issue, but I don’t understand why. The query is a substring of the login URL produced by com.predic8.membrane.core.interceptor.oauth2.authorizationservice.MembraneAuthorizationService.getLoginURL(). This function is called multiple times, and the encoding consistently works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants