feat: Option to automatically create share links for recipes in recipe actions #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 45 days with no activity. |
michael-genson
requested changes
Jan 19, 2025
There was a problem hiding this comment.
Looks great! Sorry for taking so long on this, holidays beat me up. One change to remove an API call and we're all set.
Would you also be able to add this to the docs? Just add it to the list of merge fields and a short (one sentence) description. And then also maybe change the Bring example to use the new field (instead of url).
https://docs.mealie.io/documentation/getting-started/features/#recipe-actions
| /* eslint-disable no-template-curly-in-string */ | ||
| const shareLinkRegex = /\$\{share-link-expires-seconds-[0-9]+\}/g; | ||
| const group = (await api.groups.getOne(recipe.groupId || "")).data; |
There was a problem hiding this comment.
You should be able to grab the slug from the URL instead of fetching it via the API:
import { useRoute } from "@nuxtjs/composition-api";
// put this right under "useUserApi"
const route = useRoute();
// replace the API call with this
const groupSlug = route.value.params.groupSlug || recipe.groupId || "";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Currently, when using a recipe action on a recipe that is not publicly available (due to recipe, group or household being private), the receiving service will not be able to read the recipe data.
As discussed in #4619, this PR implements an additional template option for recipe actions. The option
${share-link-expires-seconds-<x>}is automatically replaced by a newly created share link that expires afterxseconds. This makes share links usable even on private recipes, groups and households.Which issue(s) this PR fixes:
Fixes #4619
Special notes for your reviewer:
I am not completely certain, if the method to obtain the group slug is correct. Please check this part thoroughly.
Also, i have not yet created documentation for the new option - is the website documentation part of this repository?
Testing
I created a private recipe, a public recipe and multipe recipe actions
I also tested with different privacy settings in group and household. The receiver of the given action was always able to read the recipes, without being logged in using the share link.