-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - Setting theme primary colour doesn't change theme-color meta #4563
Comments
The theme color meta tag is set to primary there here: mealie/frontend/nuxt.config.js Line 363 in aceed2a
But i could reproduce it not having any effect so marking as confirmed 👍 |
Having a look at the code the problem is that the pwa theme_color does is set at build time and needs to be set at runtime. |
So it seems like the pwa module does not support runtimeConfig's. I don't have the skill or knowledge to attempt to fix that but I have got workarounds for docker and NixOS users. Docker workaroundYou need to manually change the color and build the container yourself.
NixOS workaroundI tried to do this in an override but I couldn't get there and ended up using a local copy of nixpkgs which is not ideal as you will need to
in here you want to add in the below
then commit it and rebuild
|
First Check
What is the issue you are experiencing?
I've recently customised the
THEME_DARK_ACCENT
andTHEME_LIGHT_PRIMARY
on my Mealie instance. After figuring out the caching issues, I've noticed that thetheme-color
meta tag isn't affected by this, leading to what I'd consider a UI bug:On iOS for instance, the orange banner appears as you start scrolling, which is rather jarring difference from the selected primary colour used in the banner.
Steps to Reproduce
Please provide relevant logs
n/a
Mealie Version
v2.2.0
Deployment
Other (please specify below)
Additional Deployment Details
On NixOS
The text was updated successfully, but these errors were encountered: