-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable message signing/verifying/encrypting/decrypting for all chains. #113
Conversation
Fixes #39 |
I am unable to install pull #113 on a freshly installed linux box... errors having to do with coinhash / neoscrypt: creating 'dist/Encompass-0.5.0-py2.7.egg' and adding 'build/bdist.linux-x86_64/egg' to it Installed /usr/local/lib/python2.7/dist-packages/Encompass-0.5.0-py2.7.egg when running encompass: |
@museack Sounds like you need the python-dev package. |
Needed a million other packages, too... Pull #113 appears to fix the problem. I am able to sign messages in all the currencies without generating an error. Pull 113 appears to resolve the issue I brought up. Ran into another issue, not sure what to make of it, though; not sure if it's an Encompass problem or a Linux clipboard issue.. Using xpool.ca mining site, I attempted to verify signed messages generated from #113 test. From my linux test box, verification regardless of which chain was used to sign a message. I installed the official Encompass-0.5.0 release on the test box, and verification failed using a Bitcoin chain. I use the official Encompass-0.5.0 windows to sign messages at xpool.ca (to define deposit addresses for all the mined coins) all the time. Not sure why signatures from the Linux release are failing to verify. My suspicion is that certain characters (? tabs, spaces, newlines ?) are getting mangled in the copy/paste process on Linux, which would have nothing to do with Encompass. I have not tested pull#113 on Windows; difficult for me to do without a build. I'd say #113 is closed for now and put in a PR. I'll test further with Windows when I can. |
@museack Yeah, for Encompass to run it requires some packages to be installed that aren't actually needed to use the wallet. After looking a little further, I see that the magic bytes for signed messages is "Bitcoin Signed Message:". This present a problem. The obvious solution would be to use the active chain's name, but we actually can't be sure that the name reflects exactly what is in the core client. (I think I recall at least one chain using camelcase e.g. "SomeCoin Signed Message:". So, this will require some further effort before it is ready. |
I'll reopen this when I've figured out how best to go about the aforementioned hurdle. |
All chains can now sign/verify messages, and encrypt/decrypt messages.