Encompass creates new addresses for coins unsupported by Trezor firwmare

[ELM4Ever]

With the Trezor connected, Encompass can also create addresses for MZC and VIA, even though the official firmware doesn't support them yet. Even though a msg is displayed, the danger for a user would be to forget about it, and send coins to some of those addresses, without the possibility to sign the transactions later (unless they would create their own private Trezor firmware).

Would't it be better to ask them if they have a private version of the firmware installed first? If yes, continue, if not, don't generate the addresses?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/11087073-encompass-creates-new-addresses-for-coins-unsupported-by-trezor-firwmare?utm_campaign=plugin&utm_content=tracker%2F11867956&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F11867956&utm_medium=issues&utm_source=github).

[guruvan]

If Encompass is using a wallet type (be it Trezor, or a special multisig, or whatever) that does not support the full array of coins, those chains should not be available.

It is presumable a user could do as suggested above, but it's noted that the user's coin wouldn't be lost - it would be recoverable with custom firmware, or any wallet supporting the seed/root key derivation used in the Trezor.

Also: there's no need to ask the user (who likely has no idea) if they have custom firmware - better to ask a device. But the firmware could /change/ at any point - there's no guarantee that coins supported today by X hardware will continue to be supported tomorrow.

[Kefkius]

What Encompass currently does is:

1. Ask the trezor device for a list of the currencies it supports
2. Check if the active chain's name is in that list
3. If the active chain isn't in the list, warn the user and force watching-only mode.

So it will generate keys for whatever currencies that Encompass and your Trezor firmware support. However, I see that forcing watching-only mode might not be enough. Maybe Encompass should not allow the wallet to be used in this case?

[ELM4Ever]

I would personally prefer the addresses for a currency unsupported by the firmware, not be created.

[guruvan]

@ELM4Ever I'm not sure that that's very easily achieved with the current code
@Kefkius maybe there's a way we can have Encompass simply not display chains not supported by the firmware? (or make it so that those chains are not on the list of chains to select)

Trezor is not terribly unique, funds can be recovered with any of several different apps, so I do know that even if the user were to see an MZC address, and send funds, they'd be recoverable.

[Kefkius]

@guruvan there is a way to omit unsupported chains in the "Change Currency" dialog. However, this alone doesn't address the possible situation in which a wallet is opened while the active chain is unsupported by the device's firmware.

I'm currently exploring a solution that strikes a balance between "protect the user" and "the user knows best." Possibly, the solution would be to add a warning to the status bar when a trezor wallet is using an unsupported active chain.