You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the first thing a ghost does when invited to a non-portal is to join. This allows to get a member list (to check if a bridge bot is there or to see how many users there are, to decide whether it's going to be a dm or not).
This causes some (in my view) undesired behavior. For example, on platforms where invitation is possible, all ghosts that were invited to the room before the portal was created will have membership join rather than invite. I also think that before a portal is created, Membership of ghosts should be invite, independent of the remote platform, because that's more accurate IMHO (albeit they haven't even been invited on the remote platform).
We can check whether the bridge bot is there by asking the bridge bot which rooms it is in. We should be able to obtain all other information (room name, whether it is a direct chat) without joining it. The only problem is checking the number of members, but that's only necessary if the room is marked as direct chat. We can still join the room in that case, it's a situation that wouldn't normally happen anyway, because rooms with several users aren't usually marked as direct.
If you think this is desirable, I can make a PR for it. This would be a breaking change but afaik should only affect signal and Telegram
The text was updated successfully, but these errors were encountered:
If we have access to a double puppet, we have access to all room info. If we don't have access to a double puppet, group auto-create doesn't work anyway.
Group auto-create currently obtains power levels through the bridge bot after it has joined (Telegram) or through the double puppet (I just changed the PR on mautrix-signal to not get power levels twice). So it wouldn't break.
Currently, the first thing a ghost does when invited to a non-portal is to join. This allows to get a member list (to check if a bridge bot is there or to see how many users there are, to decide whether it's going to be a dm or not).
This causes some (in my view) undesired behavior. For example, on platforms where invitation is possible, all ghosts that were invited to the room before the portal was created will have membership
join
rather thaninvite
. I also think that before a portal is created, Membership of ghosts should beinvite
, independent of the remote platform, because that's more accurate IMHO (albeit they haven't even been invited on the remote platform).We can check whether the bridge bot is there by asking the bridge bot which rooms it is in. We should be able to obtain all other information (room name, whether it is a direct chat) without joining it. The only problem is checking the number of members, but that's only necessary if the room is marked as direct chat. We can still join the room in that case, it's a situation that wouldn't normally happen anyway, because rooms with several users aren't usually marked as direct.
If you think this is desirable, I can make a PR for it. This would be a breaking change but afaik should only affect signal and Telegram
The text was updated successfully, but these errors were encountered: